From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH v2 3/4] Add library version extenstion
Date: Tue, 23 Dec 2014 10:50:58 -0500
Message-ID: <20141223155058.GG31876@hmsreliant.think-freely.org>
References: <1419109299-9603-1-git-send-email-nhorman@tuxdriver.com>
 <1419279860-16985-1-git-send-email-nhorman@tuxdriver.com>
 <1419279860-16985-3-git-send-email-nhorman@tuxdriver.com>
 <91383E96CE459D47BCE92EFBF5CE73B004F210AA@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004F210AA-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Tue, Dec 23, 2014 at 01:05:16PM +0000, Gonzalez Monroy, Sergio wrote:
> > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Neil Horman
> > Sent: Monday, December 22, 2014 8:24 PM
> >
> > a/mk/rte.lib.mk b/mk/rte.lib.mk index 7949254..ad058b5 100644
> > --- a/mk/rte.lib.mk
> > +++ b/mk/rte.lib.mk
> > @@ -166,9 +171,11 @@ endif
> >  # install lib in $(RTE_OUTPUT)/lib
> >  #
> >  $(RTE_OUTPUT)/lib/$(LIB): $(LIB)
> > +	$(eval LIBSONAME := $(basename $(LIB)))
> >  	@echo "  INSTALL-LIB $(LIB)"
> >  	@[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib
> >  	$(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib
> > +	$(Q)ln -s -f $(RTE_OUTPUT)/lib/$(LIB)
> > $(RTE_OUTPUT)/lib/$(LIBSONAME)
> > 
> Sorry Neil, I missed this before.
> We probably only want to do symbolic links for shared libs. At the moment it creates lots of unwanted links for static libs too.
> Also, I would suggest to do relative symbolic links instead.
> 
Ack, will update
Neil

> Regards,
> Sergio
> 
> > --
> > 1.9.3
> 
>