From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v3 0/6] Move EAL common functions
Date: Tue, 30 Dec 2014 16:03:37 -0500 [thread overview]
Message-ID: <20141230210337.GA2187@localhost.localdomain> (raw)
In-Reply-To: <1419957384-11693-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Tue, Dec 30, 2014 at 11:36:24AM -0500, Ravi Kerur wrote:
> Changes in v3
> Make subject line explicit on file names.
> Commit log includes function names moved to common directory.
>
> Changes in v2
> Fix patch review comments from Neil.
>
> Changes in v1
> Common functions in linuxapp and bsdapp are moved into
> librte_eal/common directory.
> New files added follow _common_ naming conventions.
>
> Following checkpatch warnings are treated as false-positive.
> WARNING: quoted string split across lines
>
> Tested against ubuntu and FreeBSD.
>
> Ravi Kerur (6):
> Move common functions in eal_debug.c
> Move common functions in eal_thread.c
> Move common functions in eal.c
> Move common functions in eal_lcore.c
> Move common functions in eal_timer.c
> Move common functions in eal_memory.c
>
> app/test/test_debug.c | 1 -
> lib/librte_eal/bsdapp/eal/Makefile | 11 +-
> lib/librte_eal/bsdapp/eal/eal.c | 233 +--------------------
> lib/librte_eal/bsdapp/eal/eal_debug.c | 113 -----------
> lib/librte_eal/bsdapp/eal/eal_lcore.c | 62 ++----
> lib/librte_eal/bsdapp/eal/eal_memory.c | 40 +---
> lib/librte_eal/bsdapp/eal/eal_thread.c | 233 ---------------------
> lib/librte_eal/bsdapp/eal/eal_timer.c | 50 +----
> lib/librte_eal/common/eal_common.c | 326 ++++++++++++++++++++++++++++++
> lib/librte_eal/common/eal_common_debug.c | 106 ++++++++++
> lib/librte_eal/common/eal_common_lcore.c | 106 ++++++++++
> lib/librte_eal/common/eal_common_memory.c | 38 +++-
> lib/librte_eal/common/eal_common_thread.c | 248 +++++++++++++++++++++++
> lib/librte_eal/common/eal_common_timer.c | 95 +++++++++
> lib/librte_eal/common/eal_externs.h | 45 +++++
> lib/librte_eal/common/eal_hugepages.h | 1 +
> lib/librte_eal/common/eal_private.h | 112 ++++++++++
> lib/librte_eal/common/include/rte_debug.h | 7 -
> lib/librte_eal/linuxapp/eal/Makefile | 11 +-
> lib/librte_eal/linuxapp/eal/eal.c | 246 +---------------------
> lib/librte_eal/linuxapp/eal/eal_debug.c | 113 -----------
> lib/librte_eal/linuxapp/eal/eal_lcore.c | 55 +----
> lib/librte_eal/linuxapp/eal/eal_memory.c | 36 +---
> lib/librte_eal/linuxapp/eal/eal_thread.c | 233 ---------------------
> lib/librte_eal/linuxapp/eal/eal_timer.c | 54 +----
> 25 files changed, 1134 insertions(+), 1441 deletions(-)
> delete mode 100644 lib/librte_eal/bsdapp/eal/eal_debug.c
> delete mode 100644 lib/librte_eal/bsdapp/eal/eal_thread.c
> create mode 100644 lib/librte_eal/common/eal_common.c
> create mode 100644 lib/librte_eal/common/eal_common_debug.c
> create mode 100644 lib/librte_eal/common/eal_common_lcore.c
> create mode 100644 lib/librte_eal/common/eal_common_thread.c
> create mode 100644 lib/librte_eal/common/eal_common_timer.c
> create mode 100644 lib/librte_eal/common/eal_externs.h
> delete mode 100644 lib/librte_eal/linuxapp/eal/eal_debug.c
> delete mode 100644 lib/librte_eal/linuxapp/eal/eal_thread.c
>
> --
> 1.9.1
>
>
Thanks
For the series
Acked-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
prev parent reply other threads:[~2014-12-30 21:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 16:36 [PATCH v3 0/6] Move EAL common functions Ravi Kerur
[not found] ` <1419957384-11693-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-30 16:37 ` [PATCH v3 1/6] Move common functions in eal_debug.c Ravi Kerur
[not found] ` <1419957440-11767-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-30 16:37 ` [PATCH v3 2/6] Move common functions in eal_thread.c Ravi Kerur
2014-12-30 16:37 ` [PATCH v3 3/6] Move common functions in eal.c Ravi Kerur
2014-12-30 16:37 ` [PATCH v3 4/6] Move common functions in eal_lcore.c Ravi Kerur
2014-12-30 16:37 ` [PATCH v3 5/6] Move common functions in eal_timer.c Ravi Kerur
[not found] ` <1419957440-11767-5-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-05 21:09 ` Thomas Monjalon
2014-12-30 16:37 ` [PATCH v3 6/6] Move common functions in eal_memory.c Ravi Kerur
[not found] ` <1419957440-11767-6-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-05 21:17 ` Thomas Monjalon
2015-01-06 17:32 ` Ravi Kerur
2014-12-30 21:03 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141230210337.GA2187@localhost.localdomain \
--to=nhorman-2xusbdqka4r54taoqtywwq@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).