From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: remove versioning of ethdev filter control function Date: Tue, 27 Feb 2018 14:45:14 +0100 Message-ID: <2014327.T8y74eV2j1@xps> References: <1519727393-138815-1-git-send-email-kirill.rybalchenko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, andrey.chilikin@intel.com To: Ferruh Yigit , Kirill Rybalchenko Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6F6B22C8 for ; Tue, 27 Feb 2018 14:45:16 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/02/2018 12:01, Ferruh Yigit: > On 2/27/2018 10:29 AM, Kirill Rybalchenko wrote: > > In 18.02 release the ABI of ethdev component was changed. > > To keep compatibility with previous versions of the library > > the versioning of rte_eth_dev_filter_ctrl function was implemented. > > As soon as deprecation note was issued in 18.02 release, there is > > no need to keep compatibility with previous versions. > > Remove the versioning of rte_eth_dev_filter_ctrl function. > > > > Signed-off-by: Kirill Rybalchenko > > --- > > lib/librte_ether/rte_ethdev.c | 155 +----------------------------------------- > > Hi Kirill, > > You need to update .map file and removed deprecation notice in this patch. And bump the ABI version in Makefile and release notes.