From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] lib/librte_ether: change socket_id passed to rte_memzone_reserve Date: Tue, 13 Jan 2015 15:24:15 -0800 Message-ID: <20150113152415.0b3d0533@urahara> References: <1421140920-9964-1-git-send-email-cian.ferriter@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Cian Ferriter Return-path: In-Reply-To: <1421140920-9964-1-git-send-email-cian.ferriter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Tue, 13 Jan 2015 09:22:00 +0000 Cian Ferriter wrote: > Change the socket id that is passed to rte_memzone_reserve from > the socket id of current logical core to the socket id of the > master_lcore. > --- > lib/librte_ether/rte_ethdev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > mode change 100644 => 100755 lib/librte_ether/rte_ethdev.c > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > old mode 100644 > new mode 100755 > index 95f2ceb..835540d > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -184,7 +184,7 @@ rte_eth_dev_data_alloc(void) > if (rte_eal_process_type() == RTE_PROC_PRIMARY){ > mz = rte_memzone_reserve(MZ_RTE_ETH_DEV_DATA, > RTE_MAX_ETHPORTS * sizeof(*rte_eth_dev_data), > - rte_socket_id(), flags); > + rte_lcore_to_socket_id(rte_get_master_lcore()), flags); > } else > mz = rte_memzone_lookup(MZ_RTE_ETH_DEV_DATA); > if (mz == NULL) Why is this a memzone at all? Seems like it should be allocated on a per-device basis on the same NUMA node of the device. Probably with rte_malloc_socket().