From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 18/22] virtio: Fix descriptor index issue Date: Thu, 15 Jan 2015 08:54:02 -0800 Message-ID: <20150115085402.4f418084@urahara> References: <1421298930-15210-1-git-send-email-changchun.ouyang@intel.com> <1421298930-15210-19-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Ouyang Changchun Return-path: In-Reply-To: <1421298930-15210-19-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, 15 Jan 2015 13:15:26 +0800 Ouyang Changchun wrote: > It should use vring descriptor index instead of used_ring index to index vq_descx. > > Signed-off-by: Changchun Ouyang > --- > lib/librte_pmd_virtio/virtio_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c b/lib/librte_pmd_virtio/virtio_rxtx.c > index 12c2310..2529dc4 100644 > --- a/lib/librte_pmd_virtio/virtio_rxtx.c > +++ b/lib/librte_pmd_virtio/virtio_rxtx.c > @@ -144,9 +144,9 @@ virtio_xmit_cleanup(struct virtqueue *vq, uint16_t num) > > used_idx = (uint16_t)(vq->vq_used_cons_idx & (vq->vq_nentries - 1)); > uep = &vq->vq_ring.used->ring[used_idx]; > - dxp = &vq->vq_descx[used_idx]; > > desc_idx = (uint16_t) uep->id; > + dxp = &vq->vq_descx[desc_idx]; > vq->vq_used_cons_idx++; > vq_ring_free_chain(vq, desc_idx); > Rather than patching a code added by earlier patch in series, why not just fix/merge the two patches?