From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 22/22] virtio: Use soft vlan strip in mergeable Rx path Date: Thu, 15 Jan 2015 08:55:57 -0800 Message-ID: <20150115085557.0d4c147f@urahara> References: <1421298930-15210-1-git-send-email-changchun.ouyang@intel.com> <1421298930-15210-23-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Ouyang Changchun Return-path: In-Reply-To: <1421298930-15210-23-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, 15 Jan 2015 13:15:30 +0800 Ouyang Changchun wrote: > To keep the consistent logic with normal Rx path, the mergeable > Rx path also needs software vlan strip/decap if it is enabled. > > Signed-off-by: Changchun Ouyang > --- > lib/librte_pmd_virtio/virtio_rxtx.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c b/lib/librte_pmd_virtio/virtio_rxtx.c > index 2529dc4..9090613 100644 > --- a/lib/librte_pmd_virtio/virtio_rxtx.c > +++ b/lib/librte_pmd_virtio/virtio_rxtx.c > @@ -568,6 +568,7 @@ virtio_recv_mergeable_pkts(void *rx_queue, > uint16_t nb_pkts) > { > struct virtqueue *rxvq = rx_queue; > + struct virtio_hw *hw = rxvq->hw; > struct rte_mbuf *rxm, *new_mbuf; > uint16_t nb_used, num, nb_rx = 0; > uint32_t len[VIRTIO_MBUF_BURST_SZ]; > @@ -674,6 +675,9 @@ virtio_recv_mergeable_pkts(void *rx_queue, > seg_res -= rcv_cnt; > } > > + if (hw->vlan_strip) > + rte_vlan_strip(rx_pkts[nb_rx]); > + > VIRTIO_DUMP_PACKET(rx_pkts[nb_rx], > rx_pkts[nb_rx]->data_len); > If you resubmit, just combine this with earlier patch that does vlan strip