From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: Q on Support for I217 and I218 Intel chipsets.
Date: Fri, 16 Jan 2015 10:52:55 +0000
Message-ID: <20150116105255.GA10516@bricha3-MOBL3>
References: <CAFb4SLBH4SJ2kL-JeCziXMtiG-g+F3b6wQ__6fSjsTWq7LzO3A@mail.gmail.com>
 <CAFb4SLAvUiiDHuevRK5Qk_GYCii7LqfOAr+ADw9ezxdEcq_QRg@mail.gmail.com>
 <CAFb4SLCr-JF9LGXF_rmW-cEHEjPkh_pP-e1kcTO0h8wQWbMvVA@mail.gmail.com>
 <3180122.JKDOmAPjoA@xps13>
 <CAFb4SLDs3wVDpOOLtH3Lg1h3+c8ZpzgKZUz3MMO17Akqoc1B9Q@mail.gmail.com>
 <2601191342CEEE43887BDE71AB977258213D5104@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: "Ananyev, Konstantin" <konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <2601191342CEEE43887BDE71AB977258213D5104-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Thu, Jan 15, 2015 at 11:54:52PM +0000, Ananyev, Konstantin wrote:
> Hi,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Ravi Kerur
> > Sent: Thursday, January 15, 2015 8:34 PM
> > To: Thomas Monjalon
> > Cc: dev-VfR2kkLFssw@public.gmane.org
> > Subject: Re: [dpdk-dev] Q on Support for I217 and I218 Intel chipsets.
> > 
> > On Wed, Jan 14, 2015 at 8:27 AM, Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> > wrote:
> > 
> > > 2015-01-09 04:41, Ravi Kerur:
> > > > Thomas,
> > > >
> > > > Please let me know how I can move forward on this. If i confine changes
> > > in
> > > > e1000/ directory to e1000_osdep.h file only and the rest in PMD will that
> > > > work? The reason I ask is because of following comment  in README file.
> > > >
> > > > ...
> > > > Few changes to the original FreeBSD sources were made to:
> > > > - Adopt it for PMD usage mode:
> > > >         e1000_osdep.c
> > > >         e1000_osdep.h
> > > > ...
> 
> Yes, if needed you can modify these files.
> In fact, these files are the only 2 that are allowed to be modified inside e1000 sub-directory.
> As I understand you plan to implement E1000_READ_FLASH_REG  and E1000_WRITE_FLASH_REG
> macros properly, correct?
> Konstantin
> 

As a cleanup we should really look to move these two files out of the e1000
subdirectory (and similarly for the ixgbe versions etc.), so as to give a cleaner
and more manageable separation between what can be edited or not.

/Bruce