From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH 03/18] fm10k: Add empty fm10k files
Date: Mon, 2 Feb 2015 08:38:48 -0500
Message-ID: <20150202133848.GA21700@hmsreliant.think-freely.org>
References: <1422594454-11045-1-git-send-email-jing.d.chen@intel.com>
 <1422594454-11045-4-git-send-email-jing.d.chen@intel.com>
 <20150131140200.GA22012@localhost.localdomain>
 <4341B239C0EFF9468EE453F9E9F4604D01661FA5@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: "Chen, Jing D" <jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D01661FA5-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Mon, Feb 02, 2015 at 05:34:43AM +0000, Chen, Jing D wrote:
> Hi Neil,
> 
> > -----Original Message-----
> > From: Neil Horman [mailto:nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org]
> > Sent: Saturday, January 31, 2015 10:02 PM
> > To: Chen, Jing D
> > Cc: dev-VfR2kkLFssw@public.gmane.org
> > Subject: Re: [dpdk-dev] [PATCH 03/18] fm10k: Add empty fm10k files
> > 
> > On Fri, Jan 30, 2015 at 01:07:19PM +0800, Chen Jing D(Mark) wrote:
> > > From: Jeff Shaw <jeffrey.b.shaw-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > >
> > > Define macros and basic data structure.
> > > Define rte_log wrapper functions.
> > >
> > > Signed-off-by: Jeff Shaw <jeffrey.b.shaw-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Signed-off-by: Chen Jing D(Mark) <jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > ---
> > >  lib/librte_pmd_fm10k/Makefile     |   96 ++++++++++++++++
> > >  lib/librte_pmd_fm10k/fm10k.h      |  224
> > +++++++++++++++++++++++++++++++++++++
> > >  lib/librte_pmd_fm10k/fm10k_logs.h |   66 +++++++++++
> > >  3 files changed, 386 insertions(+), 0 deletions(-)
> > >  create mode 100644 lib/librte_pmd_fm10k/Makefile
> > >  create mode 100644 lib/librte_pmd_fm10k/fm10k.h
> > >  create mode 100644 lib/librte_pmd_fm10k/fm10k_ethdev.c
> > >  create mode 100644 lib/librte_pmd_fm10k/fm10k_logs.h
> > >  create mode 100644 lib/librte_pmd_fm10k/fm10k_rxtx.c
> > >
> > Why are you adding empty files?
> 
> The 2 ".c" files are empty while the 2 ".h" files include code. "Makefile" includes rules to
> compile the ".c" files, I don't like to break the compile for every single patch, that's why
> the 2 ".c" files are added in this patch.
>  
That doesn't really answer the question.  Theres no need to add empty files
here.  Just add the headers alone and add the empy files on the first commit
where you have code to put in them.  Adjust the makefile so that you add them
into the compilation in the same commit that you populate the file to avoid a
FTBFS error.
Neil

> > 
> > Neil
> 
> Thanks for your comments.
> Mark
>