From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2 4/7] rte_sched: don't clear statistics when read Date: Mon, 9 Feb 2015 14:55:09 -0800 Message-ID: <20150209145509.1b7bea9b@uryu.home.lan> References: <1423116841-19799-4-git-send-email-stephen@networkplumber.org> <3EB4FA525960D640B5BDFFD6A3D89126323097BA@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" , Stephen Hemminger To: "Dumitrescu, Cristian" Return-path: In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126323097BA-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Mon, 9 Feb 2015 22:48:36 +0000 "Dumitrescu, Cristian" wrote: > Hi Stephen, > > What is the reason not to clear statistics on read? Do you have a use-case / justification for it? > > (BTW, I see you added the reset functions, but was it also your intention to remove the memset to 0 from the stats read functions? :) ) > > Regards, > Cristian Read and clear is a non-standard model. Interface statistics are not read/clear. We have lots of scripts that read statistics. Users don't like it if when stastics disappear.