From: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
To: Yong Wang <yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org"
<dev-VfR2kkLFssw@public.gmane.org>,
Stephen Hemminger
<shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 5/7] vmxnet3: get rid of DEBUG ifdefs
Date: Tue, 10 Feb 2015 18:18:22 -0800 [thread overview]
Message-ID: <20150210181822.11456a73@uryu.home.lan> (raw)
In-Reply-To: <D0FFDD6B.34A9C%yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
On Wed, 11 Feb 2015 00:54:57 +0000
Yong Wang <yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org> wrote:
> Why not
> #define VMXNET_ASSERT(x) do { (void)(0); } while (0)
>
> or simply
> #define VMXNET_ASSERT(x)
Because that will generate unused warnings in Gcc,
and by having the compiler evaluate the result it also makes
sure that junk doesn't get put in.
next prev parent reply other threads:[~2015-02-11 2:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 5:13 [PATCH 0/7] vmxnet3: driver enhancements Stephen Hemminger
[not found] ` <1418793196-17953-1-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2014-12-17 5:13 ` [PATCH 1/7] vmxnet3: add support for VLAN filtering Stephen Hemminger
[not found] ` <1418793196-17953-2-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-12 18:40 ` Yong Wang
2014-12-17 5:13 ` [PATCH 2/7] vmxnet3: remove mtu check Stephen Hemminger
[not found] ` <1418793196-17953-3-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-11 0:54 ` Yong Wang
2014-12-17 5:13 ` [PATCH 3/7] vmxnet3: add support for mulit-segment transmit Stephen Hemminger
[not found] ` <1418793196-17953-4-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-11 21:15 ` Yong Wang
2014-12-17 5:13 ` [PATCH 4/7] vmxnet3: fix link state handling Stephen Hemminger
[not found] ` <1418793196-17953-5-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-11 2:24 ` Yong Wang
2014-12-17 5:13 ` [PATCH 5/7] vmxnet3: get rid of DEBUG ifdefs Stephen Hemminger
[not found] ` <1418793196-17953-6-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-11 0:54 ` Yong Wang
[not found] ` <D0FFDD6B.34A9C%yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2015-02-11 2:18 ` Stephen Hemminger [this message]
2014-12-17 5:13 ` [PATCH 6/7] vmxnet3: support RSS and refactor offload Stephen Hemminger
[not found] ` <1418793196-17953-7-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-11 1:28 ` Yong Wang
2014-12-17 5:13 ` [PATCH 7/7] vmxnet3: support jumbo frames Stephen Hemminger
2015-01-15 11:02 ` [PATCH 0/7] vmxnet3: driver enhancements Thomas Monjalon
2015-01-22 0:49 ` Stephen Hemminger
2015-01-22 9:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150210181822.11456a73@uryu.home.lan \
--to=stephen-otpzqlsittunbdjkjebofr2eb7je58tq@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org \
--cc=yongwang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).