From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] Make -Werror optional Date: Thu, 12 Feb 2015 11:25:18 +0000 Message-ID: <20150212112518.GB10216@bricha3-MOBL3> References: <09445d1715453b2eff4399da998717b967b829b3.1423739602.git.pmatilai@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Panu Matilainen Return-path: Content-Disposition: inline In-Reply-To: <09445d1715453b2eff4399da998717b967b829b3.1423739602.git.pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, Feb 12, 2015 at 01:13:22PM +0200, Panu Matilainen wrote: > This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable > fail-on-warning compile behavior, defaulting to off. > > Failing build on warnings is a useful developer tool but its bad > for release tarballs which can and do get built with newer > compilers than what was used/available during development. Compilers > routinely add new warnings so code which built silently with cc X > might no longer do so with X+1. This doesn't make the existing code > any more buggier and failing the build in this case does not help > not help improve code quality of an already released version either. This can already be achieve by passing EXTRA_CFLAGS='-Wno-error' into the build command. I don't like changing the default option here. Better to instead document how to disable the warning flags if necessary. /Bruce