From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 0/4] Broadcom 10G NIC Poll Mode Driver Date: Thu, 12 Feb 2015 16:45:50 -0500 Message-ID: <20150212164550.0a2b8e2a@uryu.home.lan> References: <1423247795-22399-1-git-send-email-stephen@networkplumber.org> <5215853.ENRJpHG31c@xps13> <20150212063353.6fb8d6a6@uryu.home.lan> <0a8c8ae93e354bf0a74dd8ade9d1cc70@BRMWP-EXMB11.corp.brocade.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" , Stephen Hemminger To: Thomas Monjalon Return-path: In-Reply-To: <0a8c8ae93e354bf0a74dd8ade9d1cc70-sI283RzA5cMA50eAn2D9H4CDckiq/fhJZeezCHUQhQ4@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, 12 Feb 2015 14:56:06 +0000 Thomas Monjalon wrote: > 2015-02-12 06:33, Stephen Hemminger: > > On Thu, 12 Feb 2015 15:00:13 +0100 > > Thomas Monjalon wrote: > > > > > Hi Stephen, > > > > > > 2015-02-07 07:15, Stephen Hemminger: > > > > Source was from FreeBSD. > > > > > > > > changes were to make it work and lots of de-uglification. > > > > > > Maintenance would be eased by showing this work with separate commits. > > > You should at least have a patch for importing FreeBSD source without > > > modifications. > > > > > > Other comment: there could be other drivers for Broadcom devices. > > > Why not keeping the name bnx2x? > > > > > > Thanks > > > > That history is lost. > > I don't understand your answer, > and you forgot one question. > Please reply below each question. > > I said: "You should at least have a patch for importing FreeBSD source > without modfications". Is the initial FreeBSD source lost? > > Do you agree to rename to bnx2x? This was based of driver called bxe in FreeBsd but the changes are so massive that there is no point in creating such a patch except to keep some lawyer happy. 37 files changed, 33668 insertions(+), 159047 deletions(-) It might be okay to rename the visible config option and directory to bxe but not going to change internal things.