From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet-J9ArbTHlV+bR7s880joybQ@public.gmane.org>
Subject: Vhost-user early adopter feedback
Date: Wed, 18 Feb 2015 08:59:23 +0100
Message-ID: <20150218075923.GA23117@irqsave.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
To: huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>


Hello Xie,

As promized I integrated your vhost-user patchset from january in my vswi=
tch.

I just tried it, it works pretty well.

I just had a minor bug with rte_vhost_driver_register taking ownership of=
 the
string patch pointer too late. I freed it out of habit just after registe=
ring in the
caller and when ifname[IFNAMESIZ] was written the pointer was used for a =
new string I
allocated later. Maybe an early strdup() would fix this.

The last patch of your new version is really a great idea since it will
simplify a lot the socket creation and management code.

Best regards

Beno=EEt