fm10k_rxtx.c does not compile

fm10k_rxtx.c does not compile

[Wiles, Keith]

I just pulled the code and found a unused function error ‘dump_rxd()’

I had to add the ifdef around the function and remove the ifdef inside the function:

#ifdef RTE_LIBRTE_FM10K_DEBUG_RX
static inline void dump_rxd(union fm10k_rx_desc *rxd)
{
RTE_SET_USED(rxd);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
PMD_RX_LOG(DEBUG, "|     GLORT      | PKT HDR & TYPE |");
PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", rxd->d.glort,
rxd->d.data);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
PMD_RX_LOG(DEBUG, "|   VLAN & LEN   |     STATUS     |");
PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", rxd->d.vlan_len,
rxd->d.staterr);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
PMD_RX_LOG(DEBUG, "|    RESERVED    |    RSS_HASH    |");
PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", 0, rxd->d.rss);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
PMD_RX_LOG(DEBUG, "|            TIME TAG             |");
PMD_RX_LOG(DEBUG, "|       0x%016lx        |", rxd->q.timestamp);
PMD_RX_LOG(DEBUG, "+----------------|----------------+");
}
#endif

Also clang on Ubuntu 14.04 does not like the option:
  CC fm10k_pf.o
error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option]

Re: fm10k_rxtx.c does not compile

[Thomas Monjalon]

Hi Keith,

2015-02-18 17:01, Wiles, Keith:
> I just pulled the code and found a unused function error ‘dump_rxd()’
> 
> I had to add the ifdef around the function and remove the ifdef inside the function:
> 
> #ifdef RTE_LIBRTE_FM10K_DEBUG_RX
> static inline void dump_rxd(union fm10k_rx_desc *rxd)
> {
> RTE_SET_USED(rxd);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "|     GLORT      | PKT HDR & TYPE |");
> PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", rxd->d.glort,
> rxd->d.data);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "|   VLAN & LEN   |     STATUS     |");
> PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", rxd->d.vlan_len,
> rxd->d.staterr);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "|    RESERVED    |    RSS_HASH    |");
> PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", 0, rxd->d.rss);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> PMD_RX_LOG(DEBUG, "|            TIME TAG             |");
> PMD_RX_LOG(DEBUG, "|       0x%016lx        |", rxd->q.timestamp);
> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
> }
> #endif
> 
> Also clang on Ubuntu 14.04 does not like the option:
>   CC fm10k_pf.o
> error: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option]

Thanks for reporting.
I have no error with GCC 4.9.2.
Please could you try to send a patch?

Re: fm10k_rxtx.c does not compile

[Wiles, Keith]

I believe Jeff @ Intel is going to submit a patch soon.


On 2/18/15, 11:18 AM, "Thomas Monjalon" <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:

>Hi Keith,
>
>2015-02-18 17:01, Wiles, Keith:
>> I just pulled the code and found a unused function error Œdump_rxd()¹
>> 
>> I had to add the ifdef around the function and remove the ifdef inside
>>the function:
>> 
>> #ifdef RTE_LIBRTE_FM10K_DEBUG_RX
>> static inline void dump_rxd(union fm10k_rx_desc *rxd)
>> {
>> RTE_SET_USED(rxd);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "|     GLORT      | PKT HDR & TYPE |");
>> PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", rxd->d.glort,
>> rxd->d.data);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "|   VLAN & LEN   |     STATUS     |");
>> PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", rxd->d.vlan_len,
>> rxd->d.staterr);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "|    RESERVED    |    RSS_HASH    |");
>> PMD_RX_LOG(DEBUG, "|   0x%08x   |   0x%08x   |", 0, rxd->d.rss);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> PMD_RX_LOG(DEBUG, "|            TIME TAG             |");
>> PMD_RX_LOG(DEBUG, "|       0x%016lx        |", rxd->q.timestamp);
>> PMD_RX_LOG(DEBUG, "+----------------|----------------+");
>> }
>> #endif
>> 
>> Also clang on Ubuntu 14.04 does not like the option:
>>   CC fm10k_pf.o
>> error: unknown warning option '-Wno-unused-but-set-variable'; did you
>>mean '-Wno-unused-const-variable'? [-Werror,-Wunknown-warning-option]
>
>Thanks for reporting.
>I have no error with GCC 4.9.2.
>Please could you try to send a patch?

Re: fm10k_rxtx.c does not compile

[Jeff Shaw]

On Wed, Feb 18, 2015 at 05:29:02PM +0000, Wiles, Keith wrote:
> I believe Jeff @ Intel is going to submit a patch soon.

I sent patches to fix these errors.

Thanks,
Jeff