From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v6 0/7] rte_hash_crc reworked to be
 platform-independent
Date: Thu, 19 Feb 2015 15:21:30 +0000
Message-ID: <20150219152129.GA17032@bricha3-MOBL3>
References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz>
 <cover.1417092208.git.e_zhumabekov@sts.kz>
 <20150201141356.GA3141@localhost.localdomain>
 <54CEEA01.3090600@sts.kz>
 <20150202033122.GA18728@neilslaptop.think-freely.org>
 <54CF0D86.3090507@sts.kz>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Yerden Zhumabekov <e_zhumabekov-8EHiFRVJVgQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <54CF0D86.3090507-8EHiFRVJVgQ@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Mon, Feb 02, 2015 at 11:39:18AM +0600, Yerden Zhumabekov wrote:
>=20
> 02.02.2015 9:31, Neil Horman =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > On Mon, Feb 02, 2015 at 09:07:45AM +0600, Yerden Zhumabekov wrote:
> >
> >> I think so, I've just successfully built it against latest snapshot =
with
> >> RTE_TARGET
> >> equal to 'x86_64-native-linuxapp-gcc'.
> >>
> > Please confirm that setting the machine type to default builds and ru=
ns properly.
>=20
> If I understood you correctly, I set CONFIG_RTE_MACHINE=3D"default" in =
the
> config and the build was successful.
>=20

Confirmed, this worked for me too.
Looking at the patches, they look good. However, one thing I think we are=
 missing
is a unit test to verify that all our CRC implementations give the same r=
esult.
That would be useful as a sanity check of the software fallback especiall=
y. The
existing hash tests, test the hash table implementation rather than the
mathematical argorithm used to compute the hash values.

Overall, though, software fallback for CRC is something well worthwhile h=
aving.

Series Acked-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

> --=20
> Sincerely,
>=20
> Yerden Zhumabekov
> State Technical Service
> Astana, KZ
>=20
>=20