From: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
To: "Dumitrescu,
Cristian"
<cristian.dumitrescu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH v2 4/7] rte_sched: don't clear statistics when read
Date: Fri, 20 Feb 2015 17:53:27 -0800 [thread overview]
Message-ID: <20150220175327.742d8676@urahara> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891263231B3B2-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Fri, 20 Feb 2015 21:28:55 +0000
"Dumitrescu, Cristian" <cristian.dumitrescu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> Agree.
> Stephen, how about a run-time solution (I agree it would be much better, why did I not consider this in the first place?) of adding a new bool parameter in struct rte_sched_port_params: clear_stats_on_reset?
> Both stats read function get the port handle (struct rte_sched_port *) as parameter, so there should be no ripple effect to propagate this flag.
Why not read_and_clear function if absolutely necessary.
next prev parent reply other threads:[~2015-02-21 1:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 6:13 [PATCH v2 4/7] rte_sched: don't clear statistics when read Stephen Hemminger
[not found] ` <1423116841-19799-4-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-05 6:13 ` [PATCH v2 5/7] rte_sched: don't put tabs in log messages Stephen Hemminger
[not found] ` <1423116841-19799-5-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-20 18:33 ` Dumitrescu, Cristian
2015-02-05 6:14 ` [PATCH v2 6/7] rte_sched: eliminate floating point in calculating byte clock Stephen Hemminger
[not found] ` <1423116841-19799-6-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-16 22:44 ` Dumitrescu, Cristian
[not found] ` <3EB4FA525960D640B5BDFFD6A3D8912632318070-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-17 16:05 ` Stephen Hemminger
2015-02-05 6:14 ` [PATCH v2 7/7] rte_sched: rearrange data structures Stephen Hemminger
[not found] ` <1423116841-19799-7-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
2015-02-20 18:43 ` Dumitrescu, Cristian
2015-02-05 12:43 ` [PATCH v2 4/7] rte_sched: don't clear statistics when read Neil Horman
[not found] ` <20150205124330.GB28355-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2015-02-23 23:51 ` Thomas Monjalon
[not found] ` <fa17ab0c3bc041b88e18d3d76a255f13@HQ1WP-EXMB11.corp.brocade.com>
[not found] ` <fa17ab0c3bc041b88e18d3d76a255f13-2C8+kldvbBwA50eAn2D9H4CDckiq/fhJZeezCHUQhQ4@public.gmane.org>
2015-02-24 19:18 ` Stephen Hemminger
2015-02-24 20:06 ` Thomas Monjalon
2015-02-25 17:29 ` Dumitrescu, Cristian
2015-03-10 13:55 ` Thomas Monjalon
2015-02-09 22:48 ` Dumitrescu, Cristian
[not found] ` <3EB4FA525960D640B5BDFFD6A3D89126323097BA-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-09 22:55 ` Stephen Hemminger
[not found] ` <20150209145509.1b7bea9b-CA4OZQ/Yy2Lykuyl+CZolw@public.gmane.org>
2015-02-20 18:32 ` Dumitrescu, Cristian
[not found] ` <3EB4FA525960D640B5BDFFD6A3D891263231B296-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-20 19:52 ` Stephen Hemminger
2015-02-20 20:23 ` Dumitrescu, Cristian
[not found] ` <3EB4FA525960D640B5BDFFD6A3D891263231B33C-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-20 21:01 ` Thomas Monjalon
2015-02-20 21:28 ` Dumitrescu, Cristian
[not found] ` <3EB4FA525960D640B5BDFFD6A3D891263231B3B2-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-21 1:53 ` Stephen Hemminger [this message]
2015-02-23 12:06 ` Dumitrescu, Cristian
2015-02-09 23:46 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220175327.742d8676@urahara \
--to=stephen-otpzqlsittunbdjkjebofr2eb7je58tq@public.gmane.org \
--cc=cristian.dumitrescu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).