From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 5/5] Fix usage of fgets in various places Date: Mon, 23 Feb 2015 08:00:35 -0800 Message-ID: <20150223080035.001417e8@urahara> References: <1424700600-1765-1-git-send-email-pawelx.wodkowski@intel.com> <1424700600-1765-6-git-send-email-pawelx.wodkowski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Pawel Wodkowski Return-path: In-Reply-To: <1424700600-1765-6-git-send-email-pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Mon, 23 Feb 2015 15:10:00 +0100 Pawel Wodkowski wrote: > Declaration of fgets() is > char *fgets(char *str, int size, FILE *stream); > > Klocwork complain about passing "sizeof()" as size parameter since > implicit casting size_t to int might cause loss of precision. > > Signed-off-by: Pawel Wodkowski NAK this is shooting at Unicorns. The tool is the problem not the code.