From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Beno=EEt?= Canet Subject: Re: Vhost-user early adopter feedback Date: Wed, 25 Feb 2015 12:32:32 +0100 Message-ID: <20150225113232.GA21663@irqsave.net> References: <20150218075923.GA23117@irqsave.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Xie, Huawei" Return-path: Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" The Wednesday 25 Feb 2015 =E0 07:46:56 (+0000), Xie, Huawei wrote : > On 2/18/2015 3:59 PM, Beno=EEt Canet wrote: > > Hello Xie, > > > > As promized I integrated your vhost-user patchset from january in my = vswitch. > > > > I just tried it, it works pretty well. > > > > I just had a minor bug with rte_vhost_driver_register taking ownershi= p of the > > string patch pointer too late. I freed it out of habit just after reg= istering in the > > caller and when ifname[IFNAMESIZ] was written the pointer was used fo= r a new string I > > allocated later. Maybe an early strdup() would fix this. > Thanks. > Do you mean we duplicate a string from the first parameter path, like > vserver->path =3D strdup(path) ? Yes I was thinking about this. Best regards Beno=EEt > If this was the case, it was ever in my mind. We would do this if > necessary. > > > > The last patch of your new version is really a great idea since it wi= ll > > simplify a lot the socket creation and management code. > > > > Best regards > > > > Beno=EEt > > > > >=20