From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH v3 0/3] Mellanox ConnectX-3 PMD Date: Thu, 26 Feb 2015 15:49:07 +0200 Message-ID: <20150226134907.GV3806@cloudius-systems.com> References: <1424492174-27072-1-git-send-email-adrien.mazarguil@6wind.com> <1424872326-17930-1-git-send-email-adrien.mazarguil@6wind.com> <20150226115137.GU3806@cloudius-systems.com> <7873324.ABPKluIWcB@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=cp1255 Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: Content-Disposition: inline In-Reply-To: <7873324.ABPKluIWcB@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, Feb 26, 2015 at 02:36:27PM +0100, Thomas Monjalon wrote: > 2015-02-26 13:51, Gleb Natapov: > > Did git pull today. After enabling mlnx pmd compilation fails with: > >=20 > > dpdk/lib/librte_pmd_mlx4/mlx4.c: In function =91mlx4_pci_devinit=92: > > dpdk/lib/librte_pmd_mlx4/mlx4.c:4636:14: error: too few arguments to fu= nction =91rte_eth_dev_allocate=92 > > eth_dev =3D rte_eth_dev_allocate(name); >=20 > Yes, thanks for reporting. > I didn't test the disabled mlx4 after hotplug integration: > dpdk.org/browse/dpdk/commit/?id=3D9f1653e7b7e1746e7c >=20 > Clearly, I have to improve my sanity checks. > Sorry for the inconvenience. No problem, I fixed that locally, but now I see another issue. I have several PMDs statically compiled in with my application and I expect dpdk to choose correct one depending on available HW, but mlnx pmd does not behave nicely, if its initialization fails it kills entire application: EAL: PCI device 0000:03:00.0 on NUMA socket 0 EAL: probe driver: 15b3:1003 librte_pmd_mlx4 EAL: Error - exiting with code: 1 Cause: Requested device 0000:03:00.0 cannot be used This is how other pmds handle situation when init cannot be done: EAL: PCI device 0000:02:00.0 on NUMA socket 0 EAL: probe driver: 8086:1528 rte_ixgbe_pmd EAL: Not managed by known pt driver, skipped EAL: PCI device 0000:02:00.1 on NUMA socket 0 EAL: probe driver: 8086:1528 rte_ixgbe_pmd EAL: Not managed by known pt driver, skipped -- Gleb.