From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v3 0/3] Mellanox ConnectX-3 PMD Date: Fri, 27 Feb 2015 19:38:59 +0100 Message-ID: <20150227183859.GD23569@6wind.com> References: <1424492174-27072-1-git-send-email-adrien.mazarguil@6wind.com> <1424872326-17930-1-git-send-email-adrien.mazarguil@6wind.com> <20150226115137.GU3806@cloudius-systems.com> <7873324.ABPKluIWcB@xps13> <20150226134907.GV3806@cloudius-systems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: Gleb Natapov Return-path: Content-Disposition: inline In-Reply-To: <20150226134907.GV3806-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, Feb 26, 2015 at 03:49:07PM +0200, Gleb Natapov wrote: > On Thu, Feb 26, 2015 at 02:36:27PM +0100, Thomas Monjalon wrote: > > 2015-02-26 13:51, Gleb Natapov: > > > Did git pull today. After enabling mlnx pmd compilation fails with: > > >=20 > > > dpdk/lib/librte_pmd_mlx4/mlx4.c: In function =E2=80=98mlx4_pci_devi= nit=E2=80=99: > > > dpdk/lib/librte_pmd_mlx4/mlx4.c:4636:14: error: too few arguments t= o function =E2=80=98rte_eth_dev_allocate=E2=80=99 > > > eth_dev =3D rte_eth_dev_allocate(name); > >=20 > > Yes, thanks for reporting. > > I didn't test the disabled mlx4 after hotplug integration: > > dpdk.org/browse/dpdk/commit/?id=3D9f1653e7b7e1746e7c > >=20 > > Clearly, I have to improve my sanity checks. > > Sorry for the inconvenience. > No problem, I fixed that locally, but now I see another issue. I have > several PMDs statically compiled in with my application and I expect > dpdk to choose correct one depending on available HW, but mlnx pmd does > not behave nicely, if its initialization fails it kills entire > application: >=20 > EAL: PCI device 0000:03:00.0 on NUMA socket 0 > EAL: probe driver: 15b3:1003 librte_pmd_mlx4 > EAL: Error - exiting with code: 1 > Cause: Requested device 0000:03:00.0 cannot be used Forgot to set in-reply-to, but I just sent a patch to work around that issue and make mlx4 nicer: http://dpdk.org/dev/patchwork/patch/3796/ --=20 Adrien Mazarguil 6WIND