From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] config: default to shared library Date: Wed, 4 Mar 2015 10:42:13 +0000 Message-ID: <20150304104213.GE1468@bricha3-MOBL3> References: <1534932.rt5IAT3UZl@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Thomas Monjalon Return-path: Content-Disposition: inline In-Reply-To: <1534932.rt5IAT3UZl@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Wed, Mar 04, 2015 at 10:24:44AM +0100, Thomas Monjalon wrote: > Hi Panu, > > 2015-03-04 08:17, Panu Matilainen: > > With symbol versioning its vital that developers test their code in > > shared library mode, otherwise we'll be playing "add the forgotten > > symbol export" from here to eternity. > > Yes we must improve the sanity checks. > A lot of options must be tested (or removed) and not only shared libs. > But the error you reported before (missing export of rte_eth_dev_release_port) > cannot be seen even with this patch. > It means we need more tools. > Though, default configuration is not a tool. > > > By defaulting to shared we should catch more of these cases early, > > but without taking away anybodys ability to build static. > > Shared libraries are convenient for distributions but have a performance > impact. I think that static build must remain the default choice. > +1