From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH] eal: fix Wbad-function-cast warning Date: Mon, 16 Mar 2015 11:45:53 -0400 Message-ID: <20150316154553.GD16238@hmsreliant.think-freely.org> References: <1426510564-19164-1-git-send-email-john.mcnamara@intel.com> <20150316131916.GC16238@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Mcnamara, John" Return-path: Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Mon, Mar 16, 2015 at 03:04:45PM +0000, Mcnamara, John wrote: > > -----Original Message----- > > From: Neil Horman [mailto:nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org] > > Sent: Monday, March 16, 2015 1:19 PM > > To: Mcnamara, John > > Cc: dev-VfR2kkLFssw@public.gmane.org > > Subject: Re: [dpdk-dev] [PATCH] eal: fix Wbad-function-cast warning > > > > > > This looks reasonable, but it rather begs the question as to why we need > > rte_align_floor_int in the first place. Theres only one other call site, > > and it looks like it could use RTE_PTR_ALIGN_FLOOR just as easily. What > > about fixing up the second call site and removing the function to save > > some space? > > Hi Neil, > > Seems like a good idea. I'll submit a v2. > > Does rte_align_floor_int() need to be deprecated in some way or is it okay to just remove it? > > John > After the 2.0 release you should put a note in the api document, yes, but right now its not required. Though if you wanted to, I wouldn't stop you :) Neil