From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH v2 1/6] test: remove useless memset Date: Wed, 8 Apr 2015 07:49:18 -0400 Message-ID: <20150408114918.GC22959@hmsreliant.think-freely.org> References: <1428441663-3825-1-git-send-email-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev-VfR2kkLFssw@public.gmane.org To: Stephen Hemminger Return-path: Content-Disposition: inline In-Reply-To: <1428441663-3825-1-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Tue, Apr 07, 2015 at 02:20:58PM -0700, Stephen Hemminger wrote: > Remove useless memset, since dev_private is created by rte_zmalloc > it must already be zero. > > Signed-off-by: Stephen Hemminger > --- > app/test/virtual_pmd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c > index f163562..39ecf80 100644 > --- a/app/test/virtual_pmd.c > +++ b/app/test/virtual_pmd.c > @@ -565,8 +565,6 @@ virtual_ethdev_create(const char *name, struct ether_addr *mac_addr, > if (dev_private == NULL) > goto err; > > - memset(dev_private, 0, sizeof(*dev_private)); > - > snprintf(name_buf, sizeof(name_buf), "%s_rxQ", name); > dev_private->rx_queue = rte_ring_create(name_buf, MAX_PKT_BURST, socket_id, > 0); > -- > 2.1.4 > > For the series Acked-by: Neil Horman