From mboxrd@z Thu Jan 1 00:00:00 1970 From: Flavio Leitner Subject: Re: [PATCH] vhost: make vhost lockless enqueue configurable Date: Wed, 29 Apr 2015 15:07:00 -0300 Message-ID: <20150429150700.31c765df@x240.home> References: <1430306974-9618-1-git-send-email-huawei.xie@intel.com> <5540C29A.9010708@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Wed, 29 Apr 2015 13:56:58 +0200 Thomas Monjalon wrote: > 2015-04-29 13:38 GMT+02:00 Panu Matilainen : > > On 04/29/2015 02:29 PM, Huawei Xie wrote: > >> > >> vhost enabled vSwitch could have their own thread-safe vring > >> enqueue policy. > >> Add the RTE_LIBRTE_VHOST_LOCKLESS_ENQ macro for vhost lockless > >> enqueue. Turn it off by default. > >> > >> Signed-off-by: Huawei Xie > >> --- > >> config/common_linuxapp | 1 + > >> lib/librte_vhost/vhost_rxtx.c | 24 +++++++++++++++++++++++- > >> 2 files changed, 24 insertions(+), 1 deletion(-) > >> > >> diff --git a/config/common_linuxapp b/config/common_linuxapp > >> index 0078dc9..7f59499 100644 > >> --- a/config/common_linuxapp > >> +++ b/config/common_linuxapp > >> @@ -421,6 +421,7 @@ CONFIG_RTE_KNI_VHOST_DEBUG_TX=n > >> # > >> CONFIG_RTE_LIBRTE_VHOST=n > >> CONFIG_RTE_LIBRTE_VHOST_USER=y > >> +CONFIG_RTE_LIBRTE_VHOST_LOCKLESS_ENQ=n > >> CONFIG_RTE_LIBRTE_VHOST_DEBUG=n > [...] > > > > These things should be runtime configurable, not build options. > > Please do not assume everybody builds DPDK separately for each and > > every application that might ever be. > > +1 > Adding new build options must be exceptions and very well justified. +1, that's specially hard when dpdk is packaged and distributed on distros like Fedora/RHEL. fbl