From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH 00/19] Move PMDs to drivers directory Date: Wed, 13 May 2015 10:01:10 +0100 Message-ID: <20150513090109.GB12276@bricha3-MOBL3> References: <1431012951-6423-1-git-send-email-bruce.richardson@intel.com> <1431450315-13179-1-git-send-email-bruce.richardson@intel.com> <555254E5.7050906@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E90DB5680 for ; Wed, 13 May 2015 11:01:13 +0200 (CEST) Content-Disposition: inline In-Reply-To: <555254E5.7050906@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 12, 2015 at 09:30:45PM +0200, Thomas Monjalon wrote: > 2015-05-12 19:04, Bruce Richardson: > > drivers/e1000/e1000/e1000_hw.h | 1026 ++++ > > As explained in a previous comment, > http://dpdk.org/ml/archives/dev/2015-May/017509.html > I think this path would be better: > drivers/net/e1000/base/e1000_hw.h > Two reasons why I didn't create the "net" subfolder: 1. I initally forgot to consider it :-( 2. While we may at some future point have other device driver types, are we really needing to start categorising PMDs at this point? As for the base driver part, I was viewing that as a something that should be a separate patch set, since it's unrelated to moving things to the drivers subdir. I realise now, I should have replied to the original email with these points before diving into the new patchset. My bad... /Bruce