From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 01/10] examples/tep_termination:initialize the VXLAN sample Date: Fri, 15 May 2015 16:53:45 -0700 Message-ID: <20150515165345.007a8919@urahara> References: <1431670141-7835-1-git-send-email-jijiang.liu@intel.com> <1431670141-7835-2-git-send-email-jijiang.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Jijiang Liu Return-path: Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id 0AD115A40 for ; Sat, 16 May 2015 01:53:44 +0200 (CEST) Received: by pdbqa5 with SMTP id qa5so34476767pdb.0 for ; Fri, 15 May 2015 16:53:43 -0700 (PDT) In-Reply-To: <1431670141-7835-2-git-send-email-jijiang.liu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I agree that this is great to see a real example of this On Fri, 15 May 2015 14:08:52 +0800 Jijiang Liu wrote: > +static unsigned > +check_ports_num(unsigned nb_ports) > +{ > + unsigned valid_nb_ports = nb_ports; > + unsigned portid; > + > + if (nb_ports > nb_ports) { > + RTE_LOG(INFO, VHOST_PORT, "\nSpecified port number(%u) exceeds total system port number(%u)\n", > + nb_ports, nb_ports); > + nb_ports = nb_ports; This looks repetative, and wrong, is it something to shut up a compiler warning? or something that happened as result of global replace?