From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] fm10k: support XEN domain0 Date: Fri, 15 May 2015 16:57:33 -0700 Message-ID: <20150515165733.7d5571e3@urahara> References: <1431680162-13704-1-git-send-email-shaopeng.he@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Shaopeng He Return-path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by dpdk.org (Postfix) with ESMTP id CB6745A57 for ; Sat, 16 May 2015 01:57:31 +0200 (CEST) Received: by padbw4 with SMTP id bw4so35623289pad.0 for ; Fri, 15 May 2015 16:57:31 -0700 (PDT) In-Reply-To: <1431680162-13704-1-git-send-email-shaopeng.he@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 15 May 2015 16:56:02 +0800 Shaopeng He wrote: > fm10k was failing to run in XEN domain0, as the physical > memory for DMA should be allocated and translated > in a different way for XEN domain0. So > rte_memzone_reserve_bounded() should be used for DMA > memory allocation, and rte_mem_phy2mch() should be used > for DMA memory address translation to support running > fm10k PMD in XEN domain0. > > Signed-off-by: Shaopeng He I agree with Thomas that this code has spread everywhere and should be in a common spot. Also, we discovered as part of the Xen net-front driver that it should be a runtime determination, not a config option!