From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH 4/5] ixgbe: use RTE_LOG not rte_log Date: Mon, 18 May 2015 10:28:10 +0100 Message-ID: <20150518092809.GC1636@bricha3-MOBL3> References: <1431709707-5281-1-git-send-email-stephen@networkplumber.org> <1431709707-5281-5-git-send-email-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Stephen Hemminger Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 114AE9A9E for ; Mon, 18 May 2015 11:28:13 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1431709707-5281-5-git-send-email-stephen@networkplumber.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 15, 2015 at 10:08:26AM -0700, Stephen Hemminger wrote: > This driver should follow standard DPDK practice and use > RTE_LOG macro which allows setting config option to remove > the debug log messages. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/ixgbe_logs.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_logs.h b/lib/librte_pmd_ixgbe/ixgbe_logs.h > index 572e030..53ba42d 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_logs.h > +++ b/lib/librte_pmd_ixgbe/ixgbe_logs.h > @@ -35,8 +35,7 @@ > #define _IXGBE_LOGS_H_ > > #define PMD_INIT_LOG(level, fmt, args...) \ > - rte_log(RTE_LOG_ ## level, RTE_LOGTYPE_PMD, \ > - "PMD: %s(): " fmt "\n", __func__, ##args) > + RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ##args) > > #ifdef RTE_LIBRTE_IXGBE_DEBUG_INIT > #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>") > -- > 2.1.4 >