From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 5/5] ixgbe: silence noisy log messages Date: Mon, 18 May 2015 09:39:56 -0700 Message-ID: <20150518093956.0e5411d3@urahara> References: <1431709707-5281-1-git-send-email-stephen@networkplumber.org> <1431709707-5281-6-git-send-email-stephen@networkplumber.org> <20150518093201.GD1636@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id B54625A0A for ; Mon, 18 May 2015 18:39:53 +0200 (CEST) Received: by pdbqa5 with SMTP id qa5so156197125pdb.0 for ; Mon, 18 May 2015 09:39:53 -0700 (PDT) In-Reply-To: <20150518093201.GD1636@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 18 May 2015 10:32:01 +0100 Bruce Richardson wrote: > For the most part, this looks fine. However, I'm unsure about changing the log > level of the messages stating what the RX and TX burst functions in use are. I > would view this as important information that should generally be displayed as > the performance impacts of using a sub-optimal RX/TX code path are large. > > /Bruce At INFO level it shows up in log files that customers read. This is an issue where DPDK has to grow up and be ready for real world use, rather than being developer friendly. Our customers ask about every log message (believe me). So if there is no problem the drivers must be absolutely silent (STFU)