From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 2/2] i40e/base: compile fix on clang 3.3
Date: Mon, 18 May 2015 16:11:38 +0100
Message-ID: <20150518151137.GB12164@bricha3-MOBL3>
References: <1431957127-21395-1-git-send-email-helin.zhang@intel.com>
 <1431961409-22252-1-git-send-email-helin.zhang@intel.com>
 <1431961409-22252-3-git-send-email-helin.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Helin Zhang <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D077AC324
 for <dev@dpdk.org>; Mon, 18 May 2015 17:11:41 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1431961409-22252-3-git-send-email-helin.zhang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, May 18, 2015 at 11:03:29PM +0800, Helin Zhang wrote:
> Below compile error can be found on clang 3.3, which is a warning
> treated as error. Forcedly disabling the warning can fix it.
> 
> Error log:
> lib/librte_pmd_i40e/i40e/i40e_nvm.c:708:20: error: unused variable
> 'i40e_nvm_update_state_str' [-Werror,-Wunused-variable]
> STATIC const char *i40e_nvm_update_state_str[] = {
>                    ^
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  lib/librte_pmd_i40e/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
> index 911e4f5..4a5635b 100644
> --- a/lib/librte_pmd_i40e/Makefile
> +++ b/lib/librte_pmd_i40e/Makefile
> @@ -58,6 +58,7 @@ CFLAGS_BASE_DRIVER += -Wno-format
>  CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
>  CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
>  CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
> +CFLAGS_BASE_DRIVER += -Wno-unused-variable
>  else
>  CFLAGS_BASE_DRIVER  = -Wno-sign-compare
>  CFLAGS_BASE_DRIVER += -Wno-unused-value
> -- 
> 1.8.1.4
>