From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 5/5] uio: integrate MSI-X support
Date: Mon, 25 May 2015 10:42:33 -0700
Message-ID: <20150525104233.532583c6@urahara>
References: <1431970814-25951-1-git-send-email-stephen@networkplumber.org>
 <1431970814-25951-6-git-send-email-stephen@networkplumber.org>
 <5562E37B.7090605@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, cumming.lian@intel.com
To: "Liang, Cunming" <cunming.liang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com
 [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id 38133C2FC
 for <dev@dpdk.org>; Mon, 25 May 2015 19:42:30 +0200 (CEST)
Received: by pacwv17 with SMTP id wv17so74730230pac.2
 for <dev@dpdk.org>; Mon, 25 May 2015 10:42:29 -0700 (PDT)
In-Reply-To: <5562E37B.7090605@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 25 May 2015 16:55:23 +0800
"Liang, Cunming" <cunming.liang@intel.com> wrote:

> > +			irqs.fd = intr_handle->fd;
> > +
> > +		if (ioctl(intr_handle->vfio_dev_fd, UIO_MSI_IRQ_SET, &irqs) < 0) {  
> It would be strange if using vfio_dev_fd in 'uio_msix_' related function.

Just minor variable name. The whole set of fd's etc, probably need better names..