From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] virtio: fix crash if CQ is not negotiated Date: Tue, 26 May 2015 07:59:57 -0700 Message-ID: <20150526075957.431dae36@urahara> References: <1432549252-8630-1-git-send-email-damarion@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Damjan Marion Return-path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id 1336E9A92 for ; Tue, 26 May 2015 16:59:54 +0200 (CEST) Received: by padbw4 with SMTP id bw4so94694697pad.0 for ; Tue, 26 May 2015 07:59:53 -0700 (PDT) In-Reply-To: <1432549252-8630-1-git-send-email-damarion@cisco.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 25 May 2015 12:20:52 +0200 Damjan Marion wrote: > Fix NULL dereference if virtio control queue is not negotiated. > > Signed-off-by: Damjan Marion This is good belt and suspenders thing to have, but did you see early patches to check the feature bits and not call this code? Acked-by: Stephen Hemminger