From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] vhost: tcp pkt with virtio header in one desc
Date: Thu, 28 May 2015 07:50:30 -0700
Message-ID: <20150528075030.7ad1a9d4@urahara>
References: <8975cbf4-0f4d-4da4-8e45-6b75629072e1@liw0310-PC.local>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Wei li <liw@dtdream.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com
 [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id EAF635A51
 for <dev@dpdk.org>; Thu, 28 May 2015 16:50:27 +0200 (CEST)
Received: by pdfh10 with SMTP id h10so43381939pdf.3
 for <dev@dpdk.org>; Thu, 28 May 2015 07:50:27 -0700 (PDT)
In-Reply-To: <8975cbf4-0f4d-4da4-8e45-6b75629072e1@liw0310-PC.local>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 28 May 2015 16:19:44 +0800
Wei li <liw@dtdream.com> wrote:

> +		if (desc->flags & VRING_DESC_F_NEXT)
> +		{
> +			/* Discard first buffer as it is the virtio header */
> +			desc = &vq->desc[desc->next];
> +			vb_offset = 0;
> +			vb_avail = desc->len;
> +		}
> +		else /* virtio header in one desc with real pkt */
> +		{
> +			/* strip the virtio header */
> +			vb_offset = vq->vhost_hlen;
> +			vb_avail = desc->len - vq->vhost_hlen;
> +
This code looks correct, but please follow the same style as
other code in the driver. The virtio driver uses Linux/BSD
style:
	if () {
	} else {
	}