From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 0/5] multicast address filtering Date: Fri, 29 May 2015 08:17:49 -0700 Message-ID: <20150529081749.130e3636@urahara> References: <1432825523-19006-1-git-send-email-ivan.boule@6wind.com> <20150528092142.7a4241ec@urahara> <55683282.8020306@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Ivan Boule Return-path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 72EE81396 for ; Fri, 29 May 2015 17:17:48 +0200 (CEST) Received: by pacux9 with SMTP id ux9so21152552pac.3 for ; Fri, 29 May 2015 08:17:47 -0700 (PDT) In-Reply-To: <55683282.8020306@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 29 May 2015 11:33:54 +0200 Ivan Boule wrote: > On 05/28/2015 06:21 PM, Stephen Hemminger wrote: > > On Thu, 28 May 2015 17:05:18 +0200 > > Ivan Boule wrote: > > > >> Introduce PMD API to set the list of multicast MAC addresses filtered > >> by a port. > >> Implemented in the following PMDs: igb, igbvf, em, ixgbe, and ixgbevf. > >> Implementation for physical PMDs i40e, i40evf, enic, and fm10k left > >> to their respective maintainers. > >> > >> Ivan Boule (5): > >> ethdev: add multicast address filtering > >> app/testpmd: new command to add/remove multicast MAC addresses > >> e1000: add multicast MAC address filtering > >> ixgbe: add multicast MAC address filtering > >> app/testpmd: fix reply to a multicast ICMP request > >> > >> app/test-pmd/cmdline.c | 52 ++++++++++++++ > >> app/test-pmd/config.c | 142 ++++++++++++++++++++++++++++++++++++++ > >> app/test-pmd/icmpecho.c | 65 +++++++++++++++-- > >> app/test-pmd/testpmd.h | 6 ++ > >> drivers/net/e1000/em_ethdev.c | 17 +++++ > >> drivers/net/e1000/igb_ethdev.c | 18 +++++ > >> drivers/net/ixgbe/ixgbe_ethdev.c | 32 +++++++++ > >> lib/librte_ether/rte_ethdev.c | 17 +++++ > >> lib/librte_ether/rte_ethdev.h | 26 +++++++ > >> 9 files changed, 369 insertions(+), 6 deletions(-) > >> > > > > Looks good, could you also add support for virtio and vmxnet3? > > > As for physical NICs (i40e, etc.) listed above, I let the maintainers of > the remaining NICs where this function is relevant to implement and to > test it. > By the way, I supposed that Guest front-end vNICs were always in > promiscuous mode by construction. > Said differently: that all packets supplied "from the outside" to the > Host vNIC back-end driver were systematically delivered to the Guest > vNIC front-end, whatever their destination MAC address, VLAN id., etc. > Did I missed something ? > For virtio, there is a mac address table, and Multicast filtering is done by adding the multicast address to the macs table. For vmxnet3, ther is multicast address table (shared with host) so that multicast filtering can be done hypervisor.