From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 2/2] ethtool: add new library to provide
 ethtool-alike APIs
Date: Fri, 29 May 2015 08:22:19 -0700
Message-ID: <20150529082219.57614c70@urahara>
References: <1432905309-912-1-git-send-email-liang-min.wang@intel.com>
 <1432905309-912-3-git-send-email-liang-min.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, aharton@cisco.com, bruce.richardson@intle.com
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com
 [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 965601396
 for <dev@dpdk.org>; Fri, 29 May 2015 17:22:17 +0200 (CEST)
Received: by pdea3 with SMTP id a3so55798028pde.2
 for <dev@dpdk.org>; Fri, 29 May 2015 08:22:17 -0700 (PDT)
In-Reply-To: <1432905309-912-3-git-send-email-liang-min.wang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 29 May 2015 09:15:09 -0400
Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:

> +	drvinfo->n_stats = sizeof(struct rte_eth_stats) / sizeof(uint64_t);
> +	drvinfo->testinfo_len = 0;


Providing a hook to access more functionality is good and compatiablity
with old API's is helpful.  Too bad ethtool is kind of a clunky old
inflexible, and easily broken with changes. But that is not your fault.

Duplicating eth_stats in ethtool is not helpful.
This is actively discouraged for Linux device drivers.