From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Date: Thu, 4 Jun 2015 07:58:10 -0700 Message-ID: <20150604075810.0c087b21@urahara> References: <1432927612-12244-1-git-send-email-liang-min.wang@intel.com> <38737329.jBeOYmBEyN@xps13> <24712227.WkznNjn3ZB@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Wang, Liang-min" To: "Andrew Harvey (agh)" Return-path: Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 52D63C34C for ; Thu, 4 Jun 2015 16:58:11 +0200 (CEST) Received: by qkoo18 with SMTP id o18so25170293qko.1 for ; Thu, 04 Jun 2015 07:58:10 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 3 Jun 2015 02:09:39 +0000 "Andrew Harvey (agh)" wrote: > I believe that their is value in this interface for software stacks not > based on Linux being moved toward DPDK that need simple operations like > getting the mac address. Some of these stacks have a dearth of resources > available and dedicating a core/thread to KNI to get/set a mac address > is considered excessive. There are also issues with 32/64 bit kernel > integration > using KNI. If the ethtool interface is not the correct interface then > please help me > understand what should/could have been used. If ethtool is considered 'old > and clunky=C2=B9 > Stephen's and your input would be valuable in designing another interface > with > similar properties. The use-case is pretty simple and there is no plans > for moving > anything back into the kernel on the contrary its the complete opposite. >=20 > =E2=80=B9 Andy We have DPDK API's to do this, and any added wrappers make it bigger. I don't see why calling your ethtool API is better than calling rte_eth* API. If there is a missing functionality in the rte_ethXXX api's for an application then add that. For example: rte_eth_mac_addr_get()