From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 1/7] ethdev: add additional error stats
Date: Tue, 9 Jun 2015 17:29:54 -0700
Message-ID: <20150609172954.173d26d0@urahara>
References: <1433862646-91880-1-git-send-email-maryam.tahhan@intel.com>
 <1433862646-91880-2-git-send-email-maryam.tahhan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Maryam Tahhan <maryam.tahhan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qg0-f49.google.com (mail-qg0-f49.google.com
 [209.85.192.49]) by dpdk.org (Postfix) with ESMTP id 9DC8A3796
 for <dev@dpdk.org>; Wed, 10 Jun 2015 02:29:53 +0200 (CEST)
Received: by qgf75 with SMTP id 75so11163188qgf.1
 for <dev@dpdk.org>; Tue, 09 Jun 2015 17:29:52 -0700 (PDT)
In-Reply-To: <1433862646-91880-2-git-send-email-maryam.tahhan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue,  9 Jun 2015 16:10:40 +0100
Maryam Tahhan <maryam.tahhan@intel.com> wrote:

> Add MAC error and drop statistics to struct rte_eth_stats and the
> extended stats.
> Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> ---
>  lib/librte_ether/rte_ethdev.c | 4 ++++
>  lib/librte_ether/rte_ethdev.h | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 5a94654..a439b4a 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -136,6 +136,10 @@ static const struct rte_eth_xstats_name_off rte_stats_strings[] = {
>  	{"rx_flow_control_xon", offsetof(struct rte_eth_stats, rx_pause_xon)},
>  	{"tx_flow_control_xoff", offsetof(struct rte_eth_stats, tx_pause_xoff)},
>  	{"rx_flow_control_xoff", offsetof(struct rte_eth_stats, rx_pause_xoff)},
> +	{"rx_mac_err", offsetof(struct rte_eth_stats, imacerr)},
> +	{"rx_phy_err", offsetof(struct rte_eth_stats, iphyerr)},
> +	{"tx_drops", offsetof(struct rte_eth_stats, odrop)},
> +	{"rx_drops", offsetof(struct rte_eth_stats, idrop)}

Are these really generic enough to put them in ethdev?