From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH 1/3] rte_ring: remove deprecated functions Date: Fri, 12 Jun 2015 15:22:25 +0100 Message-ID: <20150612142224.GA6032@bricha3-MOBL3> References: <1434086314-14371-1-git-send-email-stephen@networkplumber.org> <557A724F.5090801@redhat.com> <20150612140023.GA6688@bricha3-MOBL3> <3193080.9j8deXXLB3@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, Stephen Hemminger To: Thomas Monjalon Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C194DADA7 for ; Fri, 12 Jun 2015 16:22:32 +0200 (CEST) Content-Disposition: inline In-Reply-To: <3193080.9j8deXXLB3@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 12, 2015 at 04:15:10PM +0200, Thomas Monjalon wrote: > 2015-06-12 15:00, Bruce Richardson: > > On Fri, Jun 12, 2015 at 08:46:55AM +0300, Panu Matilainen wrote: > > > On 06/12/2015 08:18 AM, Stephen Hemminger wrote: > > Also, patch title should be prefixed with "ring pmd" or "drivers/net/ring" rather > > than rte_ring, since this is a patch for the ring pmd, not the rte_ring library. > > Previously, there was no difference, it was only "ring". > Prefixes don't include full path nor "pmd". > Is it really important to make a difference in the commit title between ring lib > and ring pmd? Not especially important, no. However, if we are going to have prefixes to indicate what component is affected by a patch, they should at least be unique per component IMHO. /Bruce