From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/3] pmd_ring: remove deprecated functions Date: Tue, 16 Jun 2015 16:05:12 -0700 Message-ID: <20150616160512.03873f22@urahara> References: <1434387073-16951-1-git-send-email-stephen@networkplumber.org> <1434387073-16951-2-git-send-email-stephen@networkplumber.org> <20150616135216.GA9780@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Stephen Hemminger To: Bruce Richardson Return-path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 5DB8EBDC2 for ; Wed, 17 Jun 2015 01:05:11 +0200 (CEST) Received: by padev16 with SMTP id ev16so21430381pad.0 for ; Tue, 16 Jun 2015 16:05:10 -0700 (PDT) In-Reply-To: <20150616135216.GA9780@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 16 Jun 2015 14:52:16 +0100 Bruce Richardson wrote: > On Mon, Jun 15, 2015 at 09:51:11AM -0700, Stephen Hemminger wrote: > > From: Stephen Hemminger > > > > These were deprecated in 2.0 so remove them from 2.1 > > > > Signed-off-by: Stephen Hemminger > > --- > > drivers/net/ring/rte_eth_ring.c | 55 ------------------------------- > > drivers/net/ring/rte_eth_ring_version.map | 4 +-- > > 2 files changed, 1 insertion(+), 58 deletions(-) > > > [..snip..] > > diff --git a/drivers/net/ring/rte_eth_ring_version.map b/drivers/net/ring/rte_eth_ring_version.map > > index 8ad107d..5ee55d9 100644 > > --- a/drivers/net/ring/rte_eth_ring_version.map > > +++ b/drivers/net/ring/rte_eth_ring_version.map > > @@ -1,9 +1,7 @@ > > -DPDK_2.0 { > > +DPDK_2.1 { > > global: > > > > rte_eth_from_rings; > > - rte_eth_ring_pair_attach; > > - rte_eth_ring_pair_create; > > > > local: *; > > }; > > [ABI newbie question] Is this how deprecating a fn is done? We no longer have any DPDK_2.0 > version listings in the .map file? Notice the version # changed as well, so linker will generate a new version. The function was marked deprecated in last version.