From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 1/3] spinlock: add support for HTM lock
 elision for x86
Date: Thu, 18 Jun 2015 11:00:18 +0100
Message-ID: <20150618100016.GA7972@bricha3-MOBL3>
References: <1433250693-23644-1-git-send-email-roman.dementiev@intel.com>
 <1434475006-13732-1-git-send-email-roman.dementiev@intel.com>
 <1434475006-13732-2-git-send-email-roman.dementiev@intel.com>
 <10408699.ljKKKDUIsH@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 74AE7C5B8
 for <dev@dpdk.org>; Thu, 18 Jun 2015 12:00:31 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <10408699.ljKKKDUIsH@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 17, 2015 at 11:29:49PM +0200, Thomas Monjalon wrote:
> 2015-06-16 10:16, Roman Dementiev:
> > --- a/lib/librte_eal/common/include/arch/x86/rte_spinlock.h
> > +++ b/lib/librte_eal/common/include/arch/x86/rte_spinlock.h
> > @@ -39,6 +39,13 @@ extern "C" {
> >  #endif
> >  
> >  #include "generic/rte_spinlock.h"
> > +#include "rte_rtm.h"
> > +#include "rte_cpuflags.h"
> > +#include "rte_branch_prediction.h"
> > +#include <rte_common.h>
> 
> Why using angle brackets for rte_common.h?
> 
> Introducing rte_cpuflags.h in this header breaks the compilation of
> the mlx4 pmd with CONFIG_RTE_LIBRTE_MLX4_DEBUG=y.
> Indeed, it triggers the -pedantic flag which is not supported by rte_cpuflags.h.
> Maybe it's time to fix this header?

Do all our headers need to support the pedantic C flag? I don't believe this
was a previous requirement for header files. The mlx4 driver appears to be the
only place in the dpdk.org codebase where the flag actually appears - and even
then the flag disabled in mlx.c where the dpdk headers are actually included.

  73 /* DPDK headers don't like -pedantic. */$
  74 #ifdef PEDANTIC$
  75 #pragma GCC diagnostic ignored "-pedantic"$
  76 #endif$
  77 #include <rte_config.h>$
	.....


I'm just not convinced that rte_cpuflags needs to be fixed at all here.

/Bruce