From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Chemparathy Subject: Re: [PATCH v2 07/10] app/test: use struct ether_addr instead of a byte array cast Date: Mon, 22 Jun 2015 09:40:21 -0700 Message-ID: <20150622094021.356fefbd@cchemparathy-ubuntu> References: <1434735293-15469-1-git-send-email-cchemparathy@ezchip.com> <1434735293-15469-8-git-send-email-cchemparathy@ezchip.com> <20150621215624.46d69f49@uryu.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Stephen Hemminger Return-path: Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3on0058.outbound.protection.outlook.com [157.55.234.58]) by dpdk.org (Postfix) with ESMTP id B0DA2C5EE for ; Mon, 22 Jun 2015 18:40:37 +0200 (CEST) In-Reply-To: <20150621215624.46d69f49@uryu.home.lan> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 21 Jun 2015 21:56:24 -0400 Stephen Hemminger wrote: > On Fri, 19 Jun 2015 10:34:50 -0700 > Cyril Chemparathy wrote: > > > + static struct ether_addr src_mac = > > + { { 0x00, 0xFF, 0xAA, 0xFF, 0xAA, 0xFF } }; > > + static struct ether_addr dst_mac = > > + { { 0x00, 0xAA, 0xFF, 0xAA, 0xFF, 0xAA } }; > > > > Should have been const (in original code). Thanks. Fixed for v3. I'll be happy to resend the series unless you have comments on the rest of the patches.