From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Chemparathy <cchemparathy@ezchip.com>
Subject: Re: [PATCH] lib: fix RTE_MBUF_METADATA macros
Date: Mon, 22 Jun 2015 13:34:46 -0700
Message-ID: <20150622133446.0df0b07f@cchemparathy-ubuntu>
References: <1433516110-11468-1-git-send-email-danielx.t.mrzyglod@intel.com>
 <3EB4FA525960D640B5BDFFD6A3D8912632371E3A@IRSMSX108.ger.corp.intel.com>
 <29909138.qD9kMyzFYN@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from emea01-am1-obe.outbound.protection.outlook.com
 (mail-am1on0093.outbound.protection.outlook.com [157.56.112.93])
 by dpdk.org (Postfix) with ESMTP id A1DC8C67A
 for <dev@dpdk.org>; Mon, 22 Jun 2015 22:35:04 +0200 (CEST)
In-Reply-To: <29909138.qD9kMyzFYN@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 22 Jun 2015 22:16:59 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2015-06-05 15:31, Dumitrescu, Cristian:
> > > Fix RTE_MBUF_METADATA macros to allow for unaligned accesses to
> > > meta-data fields.
> > > Forcing aligned accesses is not really required, so this is
> > > removing an unneeded constraint.
> > > This issue was met during testing of the new version of the
> > > ip_pipeline application. There is no performance impact.
> > > This change has no ABI impact, as the previous code that uses
> > > aligned accesses continues to run without any issues.
> > > 
> > > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> > 
> > Ack-ed by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Applied, thanks
> 
> Cyril, feel free to fix it if it breaks with Tile arch.

Also, in the code, doesn't the following break when mbuf_priv_size != 0?

> #define RTE_MBUF_METADATA_UINT8_PTR(mbuf, offset)          \
>         (&((uint8_t *) &(mbuf)[1])[offset])


Thanks
-- Cyril.