From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH 1/2] rte_compat.h : Clean up some typos Date: Wed, 24 Jun 2015 14:06:09 -0400 Message-ID: <20150624180608.GB31530@hmsreliant.think-freely.org> References: <1435088014-18973-1-git-send-email-nhorman@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev@dpdk.org" To: "Mcnamara, John" Return-path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id EE957C4C6 for ; Wed, 24 Jun 2015 20:06:18 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 24, 2015 at 11:23:26AM +0000, Mcnamara, John wrote: > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman > > Sent: Tuesday, June 23, 2015 8:34 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 1/2] rte_compat.h : Clean up some typos > > > > Clean up some macro definition typos and comments > > Hi, > > There is a similar patch here: > > http://dpdk.org/dev/patchwork/patch/5709/ > > The other patch also removes the #ifdef RTE_BUILD_SHARED_LIB. > > John. > -- > > Yeah, I just NAK'ed that one, as it improperly removes the empty macro definitions for use when you are doing a static build. We need to keep that in place so we dont' go aliasing symbols when were not supposed to Neil