From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCHv2 1/2] rte_compat.h : Clean up some typos
Date: Wed, 24 Jun 2015 16:15:37 -0400
Message-ID: <20150624201537.GC31530@hmsreliant.think-freely.org>
References: <1435088014-18973-1-git-send-email-nhorman@tuxdriver.com>
 <1435170885-17643-1-git-send-email-nhorman@tuxdriver.com>
 <2622142.skeap4pQmM@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id D3E47C482
 for <dev@dpdk.org>; Wed, 24 Jun 2015 22:15:51 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <2622142.skeap4pQmM@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 24, 2015 at 09:41:08PM +0200, Thomas Monjalon wrote:
> 2015-06-24 14:34, Neil Horman:
> > @@ -103,7 +103,7 @@
> >  #define VERSION_SYMBOL(b, e, v)
> 
> Should be (b, e, n)
> 
> >  #define __vsym
> >  #define BASE_SYMBOL(b, n)
> 
> Should be (b, e)
> 
> > -#define BIND_DEFAULT_SYMBOL(b, v)
> > +#define BIND_DEFAULT_SYMBOL(b, e, n)
> 
> 
> 
Agreed, though thats really just cosmetic, given that the error is in the empty
defines.  Can you fix it in patchwork by hand, or would you prefer a repost?

Neil