From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/2] ixgbe: add "cold" attribute to
 setup/teardown fns
Date: Fri, 3 Jul 2015 13:03:00 -1000
Message-ID: <20150703130300.4d0f2828@uryu.home.lan>
References: <1435938006-22254-1-git-send-email-bruce.richardson@intel.com>
 <1435938006-22254-2-git-send-email-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com
 [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id 32EF62A58
 for <dev@dpdk.org>; Sat,  4 Jul 2015 01:03:06 +0200 (CEST)
Received: by pdcu2 with SMTP id u2so70996444pdc.3
 for <dev@dpdk.org>; Fri, 03 Jul 2015 16:03:05 -0700 (PDT)
In-Reply-To: <1435938006-22254-2-git-send-email-bruce.richardson@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri,  3 Jul 2015 16:40:05 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -1757,7 +1757,7 @@ ixgbe_recv_pkts_lro_bulk_alloc(void *rx_queue, struct rte_mbuf **rx_pkts,
>   * needed. If the memzone is already created, then this function returns a ptr
>   * to the old one.
>   */
> -static const struct rte_memzone *
> +static const struct rte_memzone * __attribute__((cold))
>  ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name,
>  		      uint16_t queue_id, uint32_t ring_size, int socket_id)
>  {

This function is used in multiple drivers and should really be in common code.