From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] hash: move rte_hash structure to C file and make it internal Date: Wed, 8 Jul 2015 14:21:42 +0100 Message-ID: <20150708132142.GB5708@bricha3-MOBL3> References: <1436354854-30700-1-git-send-email-pablo.de.lara.guarch@intel.com> <1436354854-30700-2-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Pablo de Lara Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 48A985A65 for ; Wed, 8 Jul 2015 15:23:26 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1436354854-30700-2-git-send-email-pablo.de.lara.guarch@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 08, 2015 at 12:27:34PM +0100, Pablo de Lara wrote: > rte_hash structure should not be a public structure, > and therefore it should be moved to the C file and be declared > as internal. rte_hash_hash implementation is also moved > to the C file, as it uses the structure. > > This patch also removes part of a unit test that was checking > a field of the structure. > > Signed-off-by: Pablo de Lara Irrespective of whether or not we change the underlying hash table implementation this looks a good change to me. The rte_hash structure should not be used directly by any applications - the APIs all take pointers to the structure, so there should be no ABI breakage from this, I think. Therefore: Acked-by: Bruce Richardson