From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v4 0/4] bnx2x: new poll mode driver Date: Thu, 9 Jul 2015 14:15:45 -0700 Message-ID: <20150709141545.4f4aa344@urahara> References: <1436465737-16818-1-git-send-email-stephen@networkplumber.org> <1616814.fx6A2joykc@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 05B555A6B for ; Thu, 9 Jul 2015 23:15:37 +0200 (CEST) Received: by pactm7 with SMTP id tm7so156430978pac.2 for ; Thu, 09 Jul 2015 14:15:36 -0700 (PDT) In-Reply-To: <1616814.fx6A2joykc@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 09 Jul 2015 22:41:23 +0200 Thomas Monjalon wrote: > REJECTED > > 2015-07-09 11:15, Stephen Hemminger: > > Changes in this version: > > - rebase for PCI uio changes > > - fix version map for 2.1 > > - add BCM57840 support > > You ignore the comments which are done. > Examples for this series: > http://dpdk.org/ml/archives/dev/2015-June/019556.html > http://dpdk.org/ml/archives/dev/2015-July/020714.html > You rarely reply to comments and you seem laughing when versioning the patches: Sorry, it was so long between versions I lost track. > v4 on 05-08: http://dpdk.org/ml/archives/dev/2015-May/017438.html > v5 on 06-17: http://dpdk.org/ml/archives/dev/2015-June/019490.html > v3 on 07-08: http://dpdk.org/ml/archives/dev/2015-July/021046.html > v4 on 08-08: http://dpdk.org/ml/archives/dev/2015-July/021277.html > > This series still has some obvious errors. > I may help to review them if you show that you care about previous comments > like doxygen errors, correct linker file syntax or even git send-email > guidelines. I will go back and fix doxygen, what is the linker issue? The send-email guidelines issues are unclear?? QLogic is helping out, there maybe a couple of other changes as well.