From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] BugFix: VFIO never works
Date: Fri, 10 Jul 2015 12:38:26 +0100
Message-ID: <20150710113826.GA10608@bricha3-MOBL3>
References: <1436514439-4893-1-git-send-email-michael.qiu@intel.com>
 <559F83AE.4050409@igel.co.jp>
 <CALwxeUsTYhjXbsR8XeFuaYeA+nzMHj1esqb_D4nb+49xCD2K7A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 33F5E9A81
 for <dev@dpdk.org>; Fri, 10 Jul 2015 13:38:31 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <CALwxeUsTYhjXbsR8XeFuaYeA+nzMHj1esqb_D4nb+49xCD2K7A@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jul 10, 2015 at 01:25:49PM +0200, David Marchand wrote:
> On Fri, Jul 10, 2015 at 10:34 AM, Tetsuya Mukawa <mukawa@igel.co.jp> wrote:
> 
> > On 2015/07/10 16:47, Michael Qiu wrote:
> > > Commit 35b3313e322b ("pci: merge mapping functions for linux and bsd")
> > >
> > > introduced a bug that all vfio will be
> > > blocked.
> > >
> > > Root cause is that VFIO_PRESENT is unaccessable in eal
> > > common level.
> > >
> > > This patch is to fix this.
> > >
> > > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > > ---
> > >  lib/librte_eal/common/eal_common_pci.c     |  2 --
> > >  lib/librte_eal/common/eal_private.h        |  3 +++
> > >  lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 10 ++++++++++
> > >  3 files changed, 13 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/lib/librte_eal/common/eal_common_pci.c
> > b/lib/librte_eal/common/eal_common_pci.c
> > > index 3805aed..f3dc697 100644
> > > --- a/lib/librte_eal/common/eal_common_pci.c
> > > +++ b/lib/librte_eal/common/eal_common_pci.c
> > > @@ -146,10 +146,8 @@ pci_map_device(struct rte_pci_device *dev)
> > >       /* try mapping the NIC resources using VFIO if it exists */
> > >       switch (dev->kdrv) {
> > >       case RTE_KDRV_VFIO:
> > > -#ifdef VFIO_PRESENT
> > >               if (pci_vfio_is_enabled())
> > >                       ret = pci_vfio_map_resource(dev);
> > > -#endif
> >
> 
> This is a common file, vfio is not available on BSD.
> I missed that during review.
> 
> Did you test build on BSD ?
>
Just tried it. BSD build fails with this patch applied.

Rather than using ifdefs, we could also look at providing dummy functions for
vfio in BSD. They would never be called by this code as drivers in BSD should
never have dev->kdrv == RTE_KDRV_VFIO.

/Bruce

diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index 12f39d9..8c1422c 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -358,6 +358,16 @@ error:
        return -1;
 }

+/*
+ * no vfio on BSD, but provide empty functions to avoid compile errors in
+ * common code.
+ */
+int
+pci_vfio_is_enabled(void) { return 0; }
+
+int
+pci_vfio_map_resource(struct rte_pci_device *dev __rte_unused) { return -1; }
+
 /* Init the PCI EAL subsystem */
 int
 rte_eal_pci_init(void)