From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <shemming@brocade.com>
Subject: igb PMD should set the default tx wthresh correctly.
Date: Thu, 16 Jul 2015 10:16:50 -0700
Message-ID: <20150716101650.45c0e25a@urahara>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com
 [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id EDC34376D
 for <dev@dpdk.org>; Thu, 16 Jul 2015 19:16:51 +0200 (CEST)
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Why doesn't igb driver set the wthresh it wants as default?

I see:
	PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance, consider setting the TX WTHRESH value to 4, 8, or 16.

But the default tx_conf has wthresh of 0.

	#define IGB_DEFAULT_TX_WTHRESH      0


Either message should be removed or default TX wthresh should change.