From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: igb PMD should set the default tx wthresh correctly. Date: Thu, 16 Jul 2015 19:49:20 -0700 Message-ID: <20150716194920.3710f25e@urahara> References: <20150716101650.45c0e25a@urahara> <6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Lu, Wenzhuo" Return-path: Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id 4D0485A59 for ; Fri, 17 Jul 2015 04:49:21 +0200 (CEST) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 17 Jul 2015 00:52:09 +0000 "Lu, Wenzhuo" wrote: > Hi Stephen, > I don't think there's a conflict. The message just reminder us that we can adjust the values to achieve better performance. > I saw ixgbe and i40e also use 0 as the same default value. To my opinion, it's good to keep the same behavior. > Thanks. In my opnion, no application should have to make special case setup for each device type. Having to have a table that lists all the parameters for each device name is not supportable or scaleable. The DPDK started out as "lets do benchmarks fast" but as a production toolkit it needs to stop having this kind of thing. The message shows up to the end-user, who thinks it is a driver bug. The "us" is now real customers not DPDK developers.